]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
scsi: target: iscsi: Use int type to store negative value
authorQianfeng Rong <rongqianfeng@vivo.com>
Tue, 2 Sep 2025 12:50:14 +0000 (20:50 +0800)
committerMartin K. Petersen <martin.petersen@oracle.com>
Wed, 10 Sep 2025 02:05:36 +0000 (22:05 -0400)
commitb0aca7ae828560b103016620be7fd4c302da4176
tree805b2c5b51cdfba17039e43a4756be7e3cddaf75
parentb620462bba6655b47d127db70d18123c7af522d4
scsi: target: iscsi: Use int type to store negative value

Change the 'ret' variable in iscsit_tmr_task_reassign() from u64 to int,
as it needs to store either negative value or zero returned by
iscsit_find_cmd_for_recovery().

Storing the negative error codes in unsigned type, or performing equality
comparisons (e.g., ret == -2), doesn't cause an issue at runtime [1] but
can be confusing.  Additionally, assigning negative error codes to
unsigned type may trigger a GCC warning when the -Wsign-conversion flag
is enabled.

No effect on runtime.

Link: https://lore.kernel.org/all/x3wogjf6vgpkisdhg3abzrx7v7zktmdnfmqeih5kosszmagqfs@oh3qxrgzkikf/
Signed-off-by: Qianfeng Rong <rongqianfeng@vivo.com>
Reviewed-by: Mike Christie <michael.christie@oracle.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
drivers/target/iscsi/iscsi_target_tmr.c