]> git.ipfire.org Git - thirdparty/git.git/commit
submodule--helper: don't redundantly check "else if (res)"
authorÆvar Arnfjörð Bjarmason <avarab@gmail.com>
Wed, 31 Aug 2022 23:18:00 +0000 (01:18 +0200)
committerJunio C Hamano <gitster@pobox.com>
Fri, 2 Sep 2022 16:16:24 +0000 (09:16 -0700)
commitb0bff0be5463ebfb75a76ff8577b90ade439a437
treee24ee1f8cdb1e998f957db50778c73240000529e
parent9d02f9499ffe7af9ce7e449e482820d437f84026
submodule--helper: don't redundantly check "else if (res)"

The "res" variable must be true at this point in update_submodule(),
as just a few lines above this we've unconditionally:

if (!res)
return 0;

So we don't need to guard the "return 1" with an "else if (res)", we
can return unconditionally at this point. See b3c5f5cb048 (submodule:
move core cmd_update() logic to C, 2022-03-15) for the initial
introduction of this code, this check of "res" has always been
redundant.

Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
Reviewed-by: Glen Choo <chooglen@google.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
builtin/submodule--helper.c