]> git.ipfire.org Git - thirdparty/git.git/commit
refs/reftable: don't fail empty transactions in repo without HEAD
authorPatrick Steinhardt <ps@pks.im>
Tue, 27 Feb 2024 14:27:39 +0000 (15:27 +0100)
committerJunio C Hamano <gitster@pobox.com>
Tue, 27 Feb 2024 21:53:39 +0000 (13:53 -0800)
commitb0f6b6b523c58cb204292455ed7121896f0aa6ed
tree3f6c2c1d7ec81ef4f7ff60e1755498231a5c597d
parentb6818ff3b11b9fdaf9d5b58c6849bfb8b06ccc83
refs/reftable: don't fail empty transactions in repo without HEAD

Under normal circumstances, it shouldn't ever happen that a repository
has no HEAD reference. In fact, git-update-ref(1) would fail any request
to delete the HEAD reference, and a newly initialized repository always
pre-creates it, too.

We have however changed git-clone(1) to partially initialize the
refdb just up to the point where remote helpers can find the
repository. With that change, we are going to run into a situation
where repositories have no refs at all.

Now there is a very particular edge case in this situation: when
preparing an empty ref transacton, we end up returning whatever value
`read_ref_without_reload()` returned to the caller. Under normal
conditions this would be fine: "HEAD" should usually exist, and thus the
function would return `0`. But if "HEAD" doesn't exist, the function
returns a positive value which we end up returning to the caller.

Fix this bug by resetting the return code to `0` and add a test.

Signed-off-by: Patrick Steinhardt <ps@pks.im>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
refs/reftable-backend.c
t/t0610-reftable-basics.sh