]> git.ipfire.org Git - thirdparty/linux.git/commit
gve: Return error for unknown admin queue command
authorAlok Tiwari <alok.a.tiwari@oracle.com>
Mon, 16 Jun 2025 05:45:01 +0000 (22:45 -0700)
committerJakub Kicinski <kuba@kernel.org>
Wed, 18 Jun 2025 01:02:29 +0000 (18:02 -0700)
commitb11344f63fdd9e8c5121148a6965b41079071dd2
tree9cdcaa8e0fb8124f101e31de30723f241a935a91
parentb52a93bbaa51a3f03561fd37221af29655db5c2a
gve: Return error for unknown admin queue command

In gve_adminq_issue_cmd(), return -EINVAL instead of 0 when an unknown
admin queue command opcode is encountered.

This prevents the function from silently succeeding on invalid input
and prevents undefined behavior by ensuring the function fails gracefully
when an unrecognized opcode is provided.

These changes improve error handling.

Signed-off-by: Alok Tiwari <alok.a.tiwari@oracle.com>
Link: https://patch.msgid.link/20250616054504.1644770-2-alok.a.tiwari@oracle.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/ethernet/google/gve/gve_adminq.c