]> git.ipfire.org Git - thirdparty/iptables.git/commit
nft: Fix leak when replacing a rule
authorPhil Sutter <phil@nwl.cc>
Wed, 6 May 2020 11:33:20 +0000 (13:33 +0200)
committerPhil Sutter <phil@nwl.cc>
Mon, 11 May 2020 12:28:29 +0000 (14:28 +0200)
commitb199aca80da5741add50cce244492cc005230b66
treeb770ea139885a8734725b3c729a87e14a3437157
parentb3b7eb6ce8773bcc76f603ebb0e606001894da34
nft: Fix leak when replacing a rule

If nft_rule_append() is called with a reference rule, it is supposed to
insert the new rule at the reference position and then remove the
reference from cache. Instead, it removed the new rule from cache again
right after inserting it. Also, it missed to free the removed rule.

Fixes: 5ca9acf51adf9 ("xtables: Fix position of replaced rules in cache")
Signed-off-by: Phil Sutter <phil@nwl.cc>
iptables/nft.c