]> git.ipfire.org Git - thirdparty/qemu.git/commit
hw/intc/aspeed: Fix IRQ handler mask check
authorSteven Lee <steven_lee@aspeedtech.com>
Thu, 20 Mar 2025 09:25:43 +0000 (17:25 +0800)
committerMichael Tokarev <mjt@tls.msk.ru>
Mon, 24 Mar 2025 20:59:53 +0000 (23:59 +0300)
commitb1efa5c2364072fa6038c1c7224c788340621456
treea777cdbbb0a3263e981f697d3369e7d6ab19737f
parentdf9168b01941d1311d4231439491614b00695344
hw/intc/aspeed: Fix IRQ handler mask check

Updated the IRQ handler mask check to AND with select variable.
This ensures that the interrupt service routine is correctly triggered
for the interrupts within the same irq group.

For example, both `eth0` and the debug UART are handled in `GICINT132`.
Without this fix, the debug console may hang if the `eth0` ISR is not
handled.

Signed-off-by: Steven Lee <steven_lee@aspeedtech.com>
Change-Id: Ic3609eb72218dfd68be6057d78b8953b18828709
Reviewed-by: Cédric Le Goater <clg@redhat.com>
Fixes: d831c5fd8682 ("aspeed/intc: Add AST2700 support")
Link: https://lore.kernel.org/qemu-devel/20250320092543.4040672-2-steven_lee@aspeedtech.com
Signed-off-by: Cédric Le Goater <clg@redhat.com>
(cherry picked from commit 7b8cbe5162e69ad629c5326bf3c158b81857955d)
(Mjt: update for before v9.2.0-2466-g5824e8bf6beb
 "hw/intc/aspeed: Introduce IRQ handler function to reduce code duplication")
Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>
hw/intc/aspeed_intc.c