]> git.ipfire.org Git - thirdparty/qemu.git/commit
hw/net/vmxnet3: allow VMXNET3_MAX_MTU itself as a value
authorFiona Ebner <f.ebner@proxmox.com>
Thu, 25 Aug 2022 09:29:10 +0000 (11:29 +0200)
committerMichael Tokarev <mjt@tls.msk.ru>
Thu, 30 Mar 2023 09:19:04 +0000 (12:19 +0300)
commitb209cc4556d56938fa8a933670b8fb98c036af37
treebf43e85a2c9b3922d710f2f8b0a94b04128d8705
parent5bfbcc3faa43e59e09e9f96ac7eebd98e05ea8e3
hw/net/vmxnet3: allow VMXNET3_MAX_MTU itself as a value

Currently, VMXNET3_MAX_MTU itself (being 9000) is not considered a
valid value for the MTU, but a guest running ESXi 7.0 might try to
set it and fail the assert [0].

In the Linux kernel, dev->max_mtu itself is a valid value for the MTU
and for the vmxnet3 driver it's 9000, so a guest running Linux will
also fail the assert when trying to set an MTU of 9000.

VMXNET3_MAX_MTU and s->mtu don't seem to be used in relation to buffer
allocations/accesses, so allowing the upper limit itself as a value
should be fine.

[0]: https://forum.proxmox.com/threads/114011/

Fixes: d05dcd94ae ("net: vmxnet3: validate configuration values during activate (CVE-2021-20203)")
Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
Signed-off-by: Jason Wang <jasowang@redhat.com>
(cherry picked from commit 099a63828130843741d317cb28e936f468b2b53b)
Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>
hw/net/vmxnet3.c