]> git.ipfire.org Git - thirdparty/haproxy.git/commit
MINOR: quic: enforce ACK reception is handled in order
authorAmaury Denoyelle <adenoyelle@haproxy.com>
Tue, 6 Aug 2024 14:30:42 +0000 (16:30 +0200)
committerAmaury Denoyelle <adenoyelle@haproxy.com>
Wed, 7 Aug 2024 09:08:20 +0000 (11:08 +0200)
commitb2282082dd163be8a083f505fa3c864d2d15e174
treeeb5f4fc701ceec34953089d27796199a2f34c9f6
parente177cf341cf3665e340855312714fe002688b2db
MINOR: quic: enforce ACK reception is handled in order

Add a new BUG_ON() in qc-stream_desc_ack(). It ensures that
acknowledgement are always notify in-order. This is because out-of-order
ACKs cannot be handled by qc_stream_desc layer which does not support
gap in STREAM sent data.

Prior to this fix, out-of-order ACKs are simply ignored without any
error. This currently cannot happen thanks to careful
qc_stream_desc_ack() invokation. If this assumption is broken in the
future by inatteion, this would cause loss of ACK notification which
will prevent qc_stream_desc release.
src/quic_stream.c