]> git.ipfire.org Git - thirdparty/qemu.git/commit
hw/riscv/virt.c: change 'aclint' TCG check
authorDaniel Henrique Barboza <dbarboza@ventanamicro.com>
Fri, 11 Aug 2023 16:02:24 +0000 (13:02 -0300)
committerAlistair Francis <alistair.francis@wdc.com>
Fri, 11 Aug 2023 18:16:26 +0000 (14:16 -0400)
commitb274c2388e9fcde75d60c6e7c7d8f888874b61b7
tree90e4d20f7e9cd17eeeaeab1ed7574def185bcb7e
parent136cb9cc03154615609d454db40e0b3dfbb4bbf3
hw/riscv/virt.c: change 'aclint' TCG check

The 'aclint' property is being conditioned with tcg acceleration in
virt_machine_class_init(). But acceleration code starts later than the
class init of the board, meaning that tcg_enabled() will be always be
false during class_init(), and the option is never being declared even
when declaring TCG accel:

$ ./build/qemu-system-riscv64 -M virt,accel=tcg,aclint=on
qemu-system-riscv64: Property 'virt-machine.aclint' not found

Fix it by moving the check from class_init() to machine_init(). Tune the
description to mention that the option is TCG only.

Cc: Philippe Mathieu-Daudé <philmd@linaro.org>
Fixes: c0716c81b ("hw/riscv/virt: Restrict ACLINT to TCG")
Resolves: https://gitlab.com/qemu-project/qemu/-/issues/1823
Signed-off-by: Daniel Henrique Barboza <dbarboza@ventanamicro.com>
Reviewed-by: Alistair Francis <alistair.francis@wdc.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Message-ID: <20230811160224.440697-2-dbarboza@ventanamicro.com>
Signed-off-by: Alistair Francis <alistair.francis@wdc.com>
hw/riscv/virt.c