]> git.ipfire.org Git - thirdparty/gcc.git/commit
avoid-store-forwarding: bail when an instruction may throw [PR117816]
authorkelefth <konstantinos.eleftheriou@vrull.eu>
Thu, 5 Dec 2024 10:11:27 +0000 (11:11 +0100)
committerPhilipp Tomsich <philipp.tomsich@vrull.eu>
Fri, 6 Dec 2024 11:36:42 +0000 (12:36 +0100)
commitb317dca04e3ffb31144f79cb804ff6835c2a9af8
tree2dd46256ca9622ef3fcab22d95a718a90e99d23c
parented210c69ce934b785410d7c1d7cd76d4ed46624d
avoid-store-forwarding: bail when an instruction may throw [PR117816]

Avoid-store-forwarding doesn't handle the case where an instruction in
the store-load sequence contains a REG_EH_REGION note, leading to the
insertion of instructions after it, while it should be the last
instruction in the basic block. This causes an ICE when compiling
using `-O -fnon-call-exceptions -favoid-store-forwarding
-fno-forward-propagate -finstrument-functions`.

This patch rejects the transformation when there are instructions in
the sequence that may throw an exeption.

PR rtl-optimization/117816

gcc/ChangeLog:

* avoid-store-forwarding.cc (store_forwarding_analyzer::avoid_store_forwarding):
Reject the transformation when having instructions that may
throw exceptions in the sequence.

gcc/testsuite/ChangeLog:

* gcc.dg/pr117816.c: New test.
gcc/avoid-store-forwarding.cc
gcc/testsuite/gcc.dg/pr117816.c [new file with mode: 0644]