]> git.ipfire.org Git - thirdparty/samba.git/commit
s4:kdc:sdb_to_hdb: Fix CID 1665466
authorGary Lockyer <gary@catalyst.net.nz>
Sun, 21 Sep 2025 21:04:02 +0000 (09:04 +1200)
committerAnoop C S <anoopcs@samba.org>
Thu, 25 Sep 2025 07:13:28 +0000 (07:13 +0000)
commitb36c49e43e92552425523deb68d355fc8c3a88fe
tree414bbd344a4394a80899125d7f0023e71dc44ff0
parente5b00b6511b53cefe4c7d9bc3db35b4cd8a0e75b
s4:kdc:sdb_to_hdb: Fix CID 1665466

Fix:
*** CID 1665466:         Resource leaks  (RESOURCE_LEAK)
/source4/kdc/sdb_to_hdb.c: 482             in sdb_entry_to_hdb_entry()
476      }
477
478      h->context = ske;
479      if (ske != NULL) {
480      ske->kdc_entry = h;
481      }
>>>     CID 1665466:         Resource leaks  (RESOURCE_LEAK)
>>>     Variable "kt" going out of scope leaks the storage "kt.val" points to.
482      return 0;
483     error:
484      free_hdb_entry(h);
485      return rc;

This is almost certainly a false positive as when kt.len == 0, kt.val will be
NULL. But changing the condition to kt.val != NULL, will not do any harm.

Signed-off-by: Gary Lockyer <gary@catalyst.net.nz>
Reviewed-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Anoop C S <anoopcs@samba.org>
Autobuild-User(master): Anoop C S <anoopcs@samba.org>
Autobuild-Date(master): Thu Sep 25 07:13:28 UTC 2025 on atb-devel-224
source4/kdc/sdb_to_hdb.c