]> git.ipfire.org Git - thirdparty/gcc.git/commit
ipa-param-manip: Be careful about a reallocating hash_map
authorMartin Jambor <mjambor@suse.cz>
Tue, 30 Nov 2021 14:35:18 +0000 (15:35 +0100)
committerMartin Jambor <mjambor@suse.cz>
Tue, 30 Nov 2021 14:35:47 +0000 (15:35 +0100)
commitb3f60112edcb85b459e60f66c44a55138b1cef49
treeacd904db8aef1424515632415781b8fd94468001
parent26493af58a1297d5d9fbb061694416deaee71220
ipa-param-manip: Be careful about a reallocating hash_map

PR 103449 revealed that when I was storing result of one hash_map
lookup into another entry in the hash_map, I was still accessing the
entry in the table, which meanwhile could get reallocated, making the
accesses invalid-after-free.

Fixed with the following, which also simplifies the return statement
which must have been true even now.

gcc/ChangeLog:

2021-11-29  Martin Liska  <mliska@suse.cz>
    Martin Jambor  <mjambor@suse.cz>

PR ipa/103449
* ipa-param-manipulation.c
(ipa_param_body_adjustments::prepare_debug_expressions): Be
careful about hash_map reallocating itself.  Simpify a return
which always returns true.
gcc/ipa-param-manipulation.c