]> git.ipfire.org Git - thirdparty/postgresql.git/commit
pgstattuple: Fix failure with pgstathashindex() for partitioned indexes
authorMichael Paquier <michael@paquier.xyz>
Tue, 19 Dec 2023 06:20:53 +0000 (15:20 +0900)
committerMichael Paquier <michael@paquier.xyz>
Tue, 19 Dec 2023 06:20:53 +0000 (15:20 +0900)
commitb4c1d255c17c2f004dcfbeeae11529271c18624c
tree4db2fce60cbb9e7d151bc1c48aa7ccee3661706e
parentb4c147ac6fd5238d2c49b6369d555f29dbfc9144
pgstattuple: Fix failure with pgstathashindex() for partitioned indexes

As coded, the function relied on index_open() when opening an index
relation, allowing partitioned indexes to be processed by
pgstathashindex().  This was leading to a "could not open file" error
because partitioned indexes have no physical files, or to a crash with
an assertion failure (like on HEAD).

This issue is fixed by applying the same checks as the other stat
functions for indexes, with a lookup at both RELKIND_INDEX and the index
AM expected.

Author: Alexander Lakhin
Discussion: https://postgr.es/m/18246-f4d9ff7cb3af77e6@postgresql.org
Backpatch-through: 12
contrib/pgstattuple/expected/pgstattuple.out
contrib/pgstattuple/pgstatindex.c
contrib/pgstattuple/sql/pgstattuple.sql