]> git.ipfire.org Git - thirdparty/qemu.git/commit
snapshot: add bdrv_drain_all() to bdrv_snapshot_delete() to avoid concurrency problem
authorZhang Haoyu <zhanghy@sangfor.com>
Tue, 21 Oct 2014 08:38:01 +0000 (16:38 +0800)
committerMichael Roth <mdroth@linux.vnet.ibm.com>
Wed, 7 Jan 2015 00:40:28 +0000 (18:40 -0600)
commitb57b7ec340c128df59337822043b878b6f08cc4a
tree0389a98d0e7a6b34008b942f5708645b18796328
parentf8c61ebdd2e59e14b6f07ee2fe3e8be011a067f1
snapshot: add bdrv_drain_all() to bdrv_snapshot_delete() to avoid concurrency problem

If there are still pending i/o while deleting snapshot,
because deleting snapshot is done in non-coroutine context, and
the pending i/o read/write (bdrv_co_do_rw) is done in coroutine context,
so it's possible to cause concurrency problem between above two operations.
Add bdrv_drain_all() to bdrv_snapshot_delete() to avoid this problem.

Signed-off-by: Zhang Haoyu <zhanghy@sangfor.com>
Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>
Message-id: 201410211637596311287@sangfor.com
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
(cherry picked from commit 3432a1929ee18e08787ce35476abd74f2c93a17c)
Signed-off-by: Michael Roth <mdroth@linux.vnet.ibm.com>
block/snapshot.c