]> git.ipfire.org Git - thirdparty/openvpn.git/commit
Fix missing return value checks in multi_process_float()
authorSteffan Karger <steffan@karger.me>
Tue, 8 Nov 2016 20:07:43 +0000 (21:07 +0100)
committerDavid Sommerseth <davids@openvpn.net>
Wed, 16 Nov 2016 10:39:38 +0000 (11:39 +0100)
commitb59fc7f42137a0474c069ab226c4d67c148e504f
tree49459fc846c36066e03a6af13bf6bddade18b16f
parent8d5b06e6fc46e214e1498352603a95028aa5c113
Fix missing return value checks in multi_process_float()

Fix the missing return value checks on hash_remove() and hash_add() by
replacing the calls with an single hash_add() call with the replace
parameters set to true so that is can't fail.  Then just ASSERT() that
this is indeed the case.

This also replaces the other add/remove combinations with a single
add-replace, because that should be slightly faster (and this is in the
'hot path').

Signed-off-by: Steffan Karger <steffan@karger.me>
Acked-by: David Sommerseth <davids@openvpn.net>
Message-Id: <1478635663-5837-1-git-send-email-steffan@karger.me>
URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg12968.html
Signed-off-by: David Sommerseth <davids@openvpn.net>
src/openvpn/multi.c