]> git.ipfire.org Git - thirdparty/qemu.git/commit
Revert "vnc: allow fall back to RAW encoding"
authorGerd Hoffmann <kraxel@redhat.com>
Tue, 21 Jan 2020 06:02:10 +0000 (07:02 +0100)
committerMichael Roth <mdroth@linux.vnet.ibm.com>
Mon, 22 Jun 2020 17:46:27 +0000 (12:46 -0500)
commitb5ba361d8f8908ab37a104b0110910926d94d57f
tree0a5cbddb803d0989d63ea4c3bde7db224d0a5add
parent52771abbfa6775db8843f2ee365d45be169887cd
Revert "vnc: allow fall back to RAW encoding"

This reverts commit de3f7de7f4e257ce44cdabb90f5f17ee99624557.

Remove VNC optimization to reencode framebuffer update as raw if it's
smaller than the default encoding.

QEMU's implementation was naive and didn't account for the ZLIB z_stream
mutating with each compression.  Because of the mutation, simply
resetting the output buffer's offset wasn't sufficient to "rewind" the
operation.  The mutated z_stream would generate future zlib blocks which
referred to symbols in past blocks which weren't sent.  This would lead
to artifacting.

Considering that ZRLE is never larger than raw and even though ZLIB can
occasionally be fractionally larger than raw, the overhead of
implementing this optimization correctly isn't worth it.

Signed-off-by: Cameron Esfahani <dirty@apple.com>
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
(cherry picked from commit 0780ec7be82dd4781e9fd216b5d99a125882ff5a)
Signed-off-by: Michael Roth <mdroth@linux.vnet.ibm.com>
ui/vnc.c