]> git.ipfire.org Git - thirdparty/qemu.git/commit
hmat acpi: Fix out of bounds access due to missing use of indirection
authorJonathan Cameron <Jonathan.Cameron@huawei.com>
Thu, 7 Mar 2024 16:03:26 +0000 (16:03 +0000)
committerMichael Tokarev <mjt@tls.msk.ru>
Wed, 13 Mar 2024 18:52:34 +0000 (21:52 +0300)
commitb5c6660ea60fa37f12b985b640b1223587e54d2c
tree5368a8231212de8c8320306eb6c12bd363439ef1
parent313e746958967a4b941ad4bbb80726727318edfa
hmat acpi: Fix out of bounds access due to missing use of indirection

With a numa set up such as

-numa nodeid=0,cpus=0 \
-numa nodeid=1,memdev=mem \
-numa nodeid=2,cpus=1

and appropriate hmat_lb entries the initiator list is correctly
computed and writen to HMAT as 0,2 but then the LB data is accessed
using the node id (here 2), landing outside the entry_list array.

Stash the reverse lookup when writing the initiator list and use
it to get the correct array index index.

Fixes: 4586a2cb83 ("hmat acpi: Build System Locality Latency and Bandwidth Information Structure(s)")
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
Message-Id: <20240307160326.31570-3-Jonathan.Cameron@huawei.com>
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
(cherry picked from commit 74e2845c5f95b0c139c79233ddb65bb17f2dd679)
Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>
hw/acpi/hmat.c