]> git.ipfire.org Git - thirdparty/postgresql.git/commit
injection_points: Add proper locking when reporting fixed-variable stats
authorMichael Paquier <michael@paquier.xyz>
Tue, 30 Sep 2025 00:02:35 +0000 (09:02 +0900)
committerMichael Paquier <michael@paquier.xyz>
Tue, 30 Sep 2025 00:02:35 +0000 (09:02 +0900)
commitb5f898944d1226f8daeb0bda58098f645582c80f
treeae6c41fa85e4a0a5cfce6e20ff2ffdc1d07d804e
parentd024160fffc8065b9b007c6be1b5f907eb2122c9
injection_points: Add proper locking when reporting fixed-variable stats

Contrary to its siblings for the archiver, the bgwriter and the
checkpointer stats, pgstat_report_inj_fixed() can be called
concurrently.  This was causing an assertion failure, while messing up
with the stats.

This code is aimed at being a template for extension developers, so it
is not a critical issue, but let's be correct.  This module has also
been useful for some benchmarking, at least for me, and that was how I
have discovered this issue.

Oversight in f68cd847fa40.

Author: Michael Paquier <michael@paquier.xyz>
Reviewed-by: Bertrand Drouvot <bertranddrouvot.pg@gmail.com>
Reviewed-by: Chao Li <li.evan.chao@gmail.com>
Reviewed-by: wenhui qiu <qiuwenhuifx@gmail.com>
Discussion: https://postgr.es/m/aNnXbAXHPFUWPIz2@paquier.xyz
Backpatch-through: 18
src/test/modules/injection_points/injection_stats_fixed.c