]> git.ipfire.org Git - thirdparty/gcc.git/commit
Fix PR 110386: backprop vs ABSU_EXPR
authorAndrew Pinski <apinski@marvell.com>
Sun, 24 Sep 2023 04:53:09 +0000 (21:53 -0700)
committerAndrew Pinski <pinskia@gmail.com>
Sun, 1 Oct 2023 18:46:42 +0000 (11:46 -0700)
commitb5fa95a3569f6ee66697876a3a380fef1b333f3d
tree55a81d4d032f7872de696ada1b260661f2788191
parentf8353d6a7cd240c4212eb267e479d4d57130da43
Fix PR 110386: backprop vs ABSU_EXPR

The issue here is that when backprop tries to go
and strip sign ops, it skips over ABSU_EXPR but
ABSU_EXPR not only does an ABS, it also changes the
type to unsigned.
Since strip_sign_op_1 is only supposed to strip off
sign changing operands and not ones that change types,
removing ABSU_EXPR here is correct. We don't handle
nop conversions so this does cause any missed optimizations either.

Committed to the GCC 13 branch after bootstrapped and
tested on x86_64-linux-gnu with no regressions.

PR tree-optimization/110386

gcc/ChangeLog:

* gimple-ssa-backprop.cc (strip_sign_op_1): Remove ABSU_EXPR.

gcc/testsuite/ChangeLog:

* gcc.c-torture/compile/pr110386-1.c: New test.
* gcc.c-torture/compile/pr110386-2.c: New test.

(cherry picked from commit 2bbac12ea7bd8a3eef5382e1b13f6019df4ec03f)
gcc/gimple-ssa-backprop.cc
gcc/testsuite/gcc.c-torture/compile/pr110386-1.c [new file with mode: 0644]
gcc/testsuite/gcc.c-torture/compile/pr110386-2.c [new file with mode: 0644]