]> git.ipfire.org Git - thirdparty/hostap.git/commit
Fix SAE state validation on AP
authorJouni Malinen <jouni@qca.qualcomm.com>
Wed, 12 Feb 2014 15:46:33 +0000 (17:46 +0200)
committerJouni Malinen <j@w1.fi>
Wed, 12 Feb 2014 15:46:33 +0000 (17:46 +0200)
commitb64afe22aa28bec9d08d6de4cba8152591b60639
tree240aeda9c61ae213a7ab89a41bc82974b95512c5
parentd6bfaaac69d452432df52be67201fbf2dddd1adc
Fix SAE state validation on AP

Confirm-before-commit validation step allowed execution to continue on
error case. This could result in segfault in sae_check_confirm() if the
temporary SAE data was not available (as it would not be, e.g., in case
of an extra SAE confirm message being received after successful
exchange). Fix this by stopping SAE processing immediately after
detecting unexpected state for confirm message. In addition, make the
public sae.c functions verify sae->tmp before dereferencing it to make
this type of bugs less likely to result in critical issues.

Signed-hostap: Jouni Malinen <jouni@qca.qualcomm.com>
src/ap/ieee802_11.c
src/common/sae.c