]> git.ipfire.org Git - thirdparty/vim.git/commit
patch 9.1.0221: lines following virt text (that fills the window) might be truncated v9.1.0221
authorDylan Thacker-Smith <dylan.ah.smith@gmail.com>
Thu, 28 Mar 2024 10:40:41 +0000 (11:40 +0100)
committerChristian Brabandt <cb@256bit.org>
Thu, 28 Mar 2024 10:51:05 +0000 (11:51 +0100)
commitb6fac4db3647179671d3267a4bcd418e92cd4572
tree3c7fd4753840e7cbfb7febe3faf8fc9930432ad0
parentc029c131ea7822514d67edb9be2de76d076aa267
patch 9.1.0221: lines following virt text (that fills the window)  might be truncated

Problem:  The if branch to set `text_prop_follows` was both checking if
          it was at the end of the buffer text line or if it was at the
          end of the screen line, but the former being true skipped
          a guard condition in the latter to only consider 'below'
          virtual text to follow. `text_prop_follows` being improperly
          set caused it to skip a conditional block to break at the end
          as well as one to move `ptr` to the end of the text line,
          while repeated for each following line of the window.
Solution: Move the check for whether 'below' virtual text should follow
          so it is also used when at the end of the buffer text line.
          (Dylan Thacker-Smith)

fixes: #12213
related: #14307

Signed-off-by: Dylan Thacker-Smith <dylan.ah.smith@gmail.com>
Signed-off-by: Christian Brabandt <cb@256bit.org>
src/drawline.c
src/testdir/dumps/Test_props_with_text_truncated_just_before_after_1.dump [new file with mode: 0644]
src/testdir/dumps/Test_props_with_text_truncated_just_before_after_2.dump [new file with mode: 0644]
src/testdir/test_textprop.vim
src/version.c