]> git.ipfire.org Git - thirdparty/linux.git/commit
btrfs: fix double iput() on inode after an error during orphan cleanup
authorFilipe Manana <fdmanana@suse.com>
Mon, 3 Jul 2023 17:15:30 +0000 (18:15 +0100)
committerDavid Sterba <dsterba@suse.com>
Tue, 18 Jul 2023 01:12:59 +0000 (03:12 +0200)
commitb777d279ff31979add57e8a3f810bceb7ef0cfb7
tree7344483aa70637996240ebae2486070706693f8d
parentf1a07c2b4e2c473ec322b8b9ece071b8c88a3512
btrfs: fix double iput() on inode after an error during orphan cleanup

At btrfs_orphan_cleanup(), if we were able to find the inode, we do an
iput() on the inode, then if btrfs_drop_verity_items() succeeds and then
either btrfs_start_transaction() or btrfs_del_orphan_item() fail, we do
another iput() in the respective error paths, resulting in an extra iput()
on the inode.

Fix this by setting inode to NULL after the first iput(), as iput()
ignores a NULL inode pointer argument.

Fixes: a13bb2c03848 ("btrfs: add missing iputs on orphan cleanup failure")
CC: stable@vger.kernel.org # 6.4
Reviewed-by: Boris Burkov <boris@bur.io>
Signed-off-by: Filipe Manana <fdmanana@suse.com>
Signed-off-by: David Sterba <dsterba@suse.com>
fs/btrfs/inode.c