]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
media: dvb-usb-v2: Fix incorrect use of transfer_flags URB_FREE_BUFFER
authorMalcolm Priestley <tvboxspy@gmail.com>
Mon, 26 Nov 2018 20:18:25 +0000 (15:18 -0500)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 9 Jan 2019 16:45:53 +0000 (17:45 +0100)
commitb78ae16c527ae09df3306c47dc060ba629c1bafb
treee1c70ddfc9aa025bc9d8b1852565fe28b11e8603
parentd7357b247f3ce1eaeb10fc4529fa8b446072773c
media: dvb-usb-v2: Fix incorrect use of transfer_flags URB_FREE_BUFFER

commit 255095fa7f62ff09b6f61393414535c59c6b4cb0 upstream.

commit 1a0c10ed7bb1 ("media: dvb-usb-v2: stop using coherent memory for
URBs") incorrectly adds URB_FREE_BUFFER after every urb transfer.

It cannot use this flag because it reconfigures the URBs accordingly
to suit connected devices. In doing a call to usb_free_urb is made and
invertedly frees the buffers.

The stream buffer should remain constant while driver is up.

Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
CC: stable@vger.kernel.org # v4.18+
Signed-off-by: Sean Young <sean@mess.org>
Signed-off-by: Mauro Carvalho Chehab <mchehab+samsung@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/media/usb/dvb-usb-v2/usb_urb.c