]> git.ipfire.org Git - people/ms/linux.git/commit
mm: Fix generic hugetlb pte check return type.
authorDavid Miller <davem@davemloft.net>
Wed, 2 Oct 2013 18:25:09 +0000 (14:25 -0400)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 14 Oct 2013 01:14:30 +0000 (18:14 -0700)
commitb8a118efef12f11e6f726d46b9d918200d59e479
tree3d41c27b93380770f548b7a1a3bece1e1f4e5900
parent8e810c7aabe8a9c7451a7ef2fd2fe09ad6fafae5
mm: Fix generic hugetlb pte check return type.

[ Upstream commit 26794942461f438a6bc725ec7294b08a6bd782c4 ]

The include/asm-generic/hugetlb.h stubs that just vector huge_pte_*()
calls to the pte_*() implementations won't work in certain situations.

x86 and sparc, for example, return "unsigned long" from the bit
checks, and just go "return pte_val(pte) & PTE_BIT_FOO;"

But since huge_pte_*() returns 'int', if any high bits on 64-bit are
relevant, they get chopped off.

The net effect is that we can loop forever trying to COW a huge page,
because the huge_pte_write() check signals false all the time.

Reported-by: Gurudas Pai <gurudas.pai@oracle.com>
Tested-by: Gurudas Pai <gurudas.pai@oracle.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Acked-by: David Rientjes <rientjes@google.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
include/asm-generic/hugetlb.h