]> git.ipfire.org Git - thirdparty/postgresql.git/commit
Remove assertion from PortalRunMulti
authorÁlvaro Herrera <alvherre@kurilemu.de>
Thu, 17 Jul 2025 15:40:22 +0000 (17:40 +0200)
committerÁlvaro Herrera <alvherre@kurilemu.de>
Thu, 17 Jul 2025 15:40:22 +0000 (17:40 +0200)
commitb9a89682846f0dc47fef9d80219ba8fe0d9779c7
tree7ae588f197b94402c72b0986388c82cb05c92459
parent01d1c45c0a8e79f9749292ede89b163f89fabf83
Remove assertion from PortalRunMulti

We have an assertion to ensure that a command tag has been assigned by
the time we're done executing, but if we happen to execute a command
with no queries, the assertion would fail.  Per discussion, rather than
contort things to get a tag assigned, just remove the assertion.

Oversight in 2f9661311b83.  That commit also retained a comment that
explained logic that had been adjacent to it but diffused into various
places, leaving none apt to keep part of the comment.  Remove that part,
and rewrite what remains for extra clarity.

Bug: #18984
Backpatch-through: 13
Reported-by: Aleksander Alekseev <aleksander@tigerdata.com>
Reviewed-by: Tom Lane <tgl@sss.pgh.pa.us>
Reviewed-by: Michaël Paquier <michael@paquier.xyz>
Discussion: https://postgr.es/m/18984-0f4778a6599ac3ae@postgresql.org
src/backend/tcop/pquery.c