]> git.ipfire.org Git - thirdparty/gcc.git/commit
i386: Update -mfunction-return= for return with pop
authorH.J. Lu <hongjiu.lu@intel.com>
Mon, 26 Feb 2018 15:29:30 +0000 (15:29 +0000)
committerH.J. Lu <hjl@gcc.gnu.org>
Mon, 26 Feb 2018 15:29:30 +0000 (07:29 -0800)
commitb9d676b3c0f53504d48bc3f0fe3fec6dbddaed6e
tree853e15f1381e1c82054c7094e406272fdfb7047e
parent98c26210e2a36a4b379e4a711d34dda92f076acf
i386: Update -mfunction-return= for return with pop

When -mfunction-return= is used, simple_return_pop_internal should pop
return address into ECX register, adjust stack by bytes to pop from stack
and jump to the return thunk via ECX register.

Tested on i686 and x86-64.

PR target/84530
* config/i386/i386-protos.h (ix86_output_indirect_jmp): Remove
the bool argument.
(ix86_output_indirect_function_return): New prototype.
(ix86_split_simple_return_pop_internal): Likewise.
* config/i386/i386.c (indirect_return_via_cx): New.
(indirect_return_via_cx_bnd): Likewise.
(indirect_thunk_name): Handle return va CX_REG.
(output_indirect_thunk_function): Create alias for
__x86_return_thunk_[re]cx and __x86_return_thunk_[re]cx_bnd.
(ix86_output_indirect_jmp): Remove the bool argument.
(ix86_output_indirect_function_return): New function.
(ix86_split_simple_return_pop_internal): Likewise.
* config/i386/i386.md (*indirect_jump): Don't pass false
to ix86_output_indirect_jmp.
(*tablejump_1): Likewise.
(simple_return_pop_internal): Change it to define_insn_and_split.
Call ix86_split_simple_return_pop_internal to split it for
-mfunction-return=.
(simple_return_indirect_internal): Call
ix86_output_indirect_function_return instead of
ix86_output_indirect_jmp.

gcc/testsuite/

PR target/84530
* gcc.target/i386/ret-thunk-22.c: New test.
* gcc.target/i386/ret-thunk-23.c: Likewise.
* gcc.target/i386/ret-thunk-24.c: Likewise.
* gcc.target/i386/ret-thunk-25.c: Likewise.
* gcc.target/i386/ret-thunk-26.c: Likewise.

From-SVN: r257992
gcc/ChangeLog
gcc/config/i386/i386-protos.h
gcc/config/i386/i386.c
gcc/config/i386/i386.md
gcc/testsuite/ChangeLog
gcc/testsuite/gcc.target/i386/ret-thunk-22.c [new file with mode: 0644]
gcc/testsuite/gcc.target/i386/ret-thunk-23.c [new file with mode: 0644]
gcc/testsuite/gcc.target/i386/ret-thunk-24.c [new file with mode: 0644]
gcc/testsuite/gcc.target/i386/ret-thunk-25.c [new file with mode: 0644]
gcc/testsuite/gcc.target/i386/ret-thunk-26.c [new file with mode: 0644]