]> git.ipfire.org Git - thirdparty/Python/cpython.git/commit
gh-71936: Fix race condition in multiprocessing.Pool (GH-124973)
authorPetr Viktorin <encukou@gmail.com>
Wed, 13 Nov 2024 09:25:10 +0000 (10:25 +0100)
committerGitHub <noreply@github.com>
Wed, 13 Nov 2024 09:25:10 +0000 (10:25 +0100)
commitba088c8f9cf7163b0f28c507cb1343befe21997e
treed22735706db59196f6cbf45d1566815279dc2801
parent1e40c5ba47780ddd91868abb3aa064f5ba3015e4
gh-71936: Fix race condition in multiprocessing.Pool (GH-124973)

* gh-71936: Fix race condition in multiprocessing.Pool

Proxes of shared objects register a Finalizer in BaseProxy._incref(), and it
will call BaseProxy._decref() when it is GCed. This may cause a race condition
with Pool(maxtasksperchild=None) on Windows.

A connection would be closed and raised TypeError when a GC occurs between
_ConnectionBase._check_writable() and _ConnectionBase._send_bytes() in
_ConnectionBase.send() in the second or later task, and a new object
is allocated that shares the id() of a previously deleted one.

Instead of using the id() of the token (or the proxy), use a unique,
non-reusable number.

Co-Authored-By: Akinori Hattori <hattya@gmail.com>
Lib/multiprocessing/managers.py
Misc/ACKS
Misc/NEWS.d/next/Library/2022-10-15-10-18-20.gh-issue-71936.MzJjc_.rst [new file with mode: 0644]