]> git.ipfire.org Git - people/arne_f/kernel.git/commit
V4L: v4l2-common: remove incorrect MODULE test
authorHans Verkuil <hverkuil@xs4all.nl>
Tue, 31 Mar 2009 13:23:04 +0000 (09:23 -0400)
committerChris Wright <chrisw@sous-sol.org>
Thu, 2 Apr 2009 20:55:20 +0000 (13:55 -0700)
commitbb70446264cc380f4167c9bea4df2c12ad564541
tree337522249e3ae72249fd450a6b2c0c1ef5c4e91d
parent5d8a29ae73aa9a0dac7aa7ec970bbe2d8f45b189
V4L: v4l2-common: remove incorrect MODULE test

upstream commit: d64260d58865004c6354e024da3450fdd607ea07

v4l2-common doesn't have to be a module for it to call request_module().
Just remove that test.

Without this patch loading ivtv as a module while v4l2-common is compiled
into the kernel will cause a delayed load of the i2c modules that ivtv
needs since request_module is never called directly.

While it is nice to see the delayed load in action, it is not so nice in
that ivtv fails to do a lot of necessary i2c initializations and will oops
later on with a division-by-zero.

Thanks to Mark Lord for reporting this and helping me figure out what was
wrong.

Thanks-to: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
Thanks-to: Mark Lord <lkml@rtr.ca>
Signed-off-by: Hans Verkuil <hverkuil@xs4all.nl>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
Signed-off-by: Michael Krufky <mkrufky@linuxtv.org>
Signed-off-by: Chris Wright <chrisw@sous-sol.org>
drivers/media/video/v4l2-common.c