]> git.ipfire.org Git - thirdparty/squid.git/commit
Fix parsing of legacy url_rewrite_program responses (#2420)
authorRenaud Métrich <1163635+rmetrich@users.noreply.github.com>
Wed, 20 May 2026 23:02:33 +0000 (23:02 +0000)
committerSquid Anubis <squid-anubis@squid-cache.org>
Wed, 20 May 2026 23:02:38 +0000 (23:02 +0000)
commitbb854bb95ae22bffb40c66b1fe3bb344f1563d7e
tree1b90f0617ac64a35ffcfc777599348554f44dd01
parent46f3f80c309059d77f7f777195f4dc1caebf13ce
Fix parsing of legacy url_rewrite_program responses (#2420)

Legacy helper responses start with a URL instead of `OK rewrite_url=...`
and such. 2016 commit ddc77a2e introduced two bugs when handling legacy
responses:

* Response parsing code triggered MemBuf assertions when 0-terminating
  the parsing buffer for certain URLs. The bug affected legacy helper
  responses with and without space characters.

* Squid code attempted to accept/use helper-returned URLs with embedded
  space character(s), despite a WARNING implying that the post-space
  characters are not going to become a part of the new URL.
CONTRIBUTORS
src/redirect.cc