]> git.ipfire.org Git - thirdparty/qemu.git/commit
qtest/numa-test: Use detailed -smp CLIs in test_def_cpu_split
authorYanan Wang <wangyanan55@huawei.com>
Wed, 29 Sep 2021 02:58:08 +0000 (10:58 +0800)
committerPaolo Bonzini <pbonzini@redhat.com>
Fri, 1 Oct 2021 13:27:56 +0000 (15:27 +0200)
commitbbb0c0ec6da8a739b02fbff941b44afc5513d6e4
treee1cdf615df0fa614a76edc9241d835507094893f
parentafc8e9aaa7915ebfe1af8eba6994a38b3e556ba9
qtest/numa-test: Use detailed -smp CLIs in test_def_cpu_split

Since commit 80d7835749 (qemu-options: rewrite help for -smp options),
the preference of sockets/cores in -smp parsing is considered liable
to change, and actually we are going to change it in a coming commit.
So it'll be more stable to use detailed -smp CLIs in the testcases
that have strong dependency on the parsing results.

Currently, test_def_cpu_split use "-smp 8" and will get 8 CPU sockets
based on current parsing rule. But if we change to prefer cores over
sockets we will get one CPU socket with 8 cores, and this testcase
will not get expected numa set by default on x86_64 (Ok on aarch64).

So now explicitly use "-smp 8,sockets=8" to avoid affect from parsing
logic change.

Signed-off-by: Yanan Wang <wangyanan55@huawei.com>
Reviewed-by: Andrew Jones <drjones@redhat.com>
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Message-Id: <20210929025816.21076-9-wangyanan55@huawei.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
tests/qtest/numa-test.c