]> git.ipfire.org Git - thirdparty/asterisk.git/commit
Migrate hashtest/hashtest2 to be unit tests.
authorDavid M. Lee <dlee@digium.com>
Thu, 15 Nov 2012 23:38:44 +0000 (23:38 +0000)
committerDavid M. Lee <dlee@digium.com>
Thu, 15 Nov 2012 23:38:44 +0000 (23:38 +0000)
commitbbf35263149dafea81b1bce038714057efc610f2
treecc87e7fddc7cc4902b8812077d58dfc80d26a9e5
parent0c77685b91881c78d25229c50c69b8218ed6a120
Migrate hashtest/hashtest2 to be unit tests.

Both hashtest and hashtest2 are manual testing apps that thrash hash
tables (hashtab and ao2 containers, respectively), by spinning up
several threads that randomly insert, delete, lookup and iterate over
the hash table. If the app doesn't crash, the hash table probably passes
the test. Those utils are not a part of the typical Asterisk build, so
they do not usually get compiled. This all makes them less that useful.

This patch removes those manual test programs and replaces them with
Asterisk unit test modules (test_{hashtab,astobj2}_thrash.so). It also
attempts to make the tests more deterministic.

* Rather than spinning up some number of threads that operate on the
  hash table randomly, spin up four threads that concurrenly add,
  remove, lookup and iterate over the hash table.
* Each thread checks the state of the hash table both during and after
  execution, and indicates a test failure if things are not as expected.
* Each thread times out after 60 seconds to prevent deadlocking the unit
  test run.

(closes issue ASTERISK-20505)
Reported by: Matt Jordan
Review: https://reviewboard.asterisk.org/r/2189/
........

Merged revisions 376306 from http://svn.asterisk.org/svn/asterisk/branches/1.8
........

Merged revisions 376315 from http://svn.asterisk.org/svn/asterisk/branches/10

git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/11@376339 65c4cc65-6c06-0410-ace0-fbb531ad65f3
include/asterisk/hashtab.h
tests/test_astobj2_thrash.c [new file with mode: 0644]
tests/test_hashtab_thrash.c [new file with mode: 0644]
utils/Makefile
utils/hashtest.c [deleted file]
utils/hashtest2.c [deleted file]
utils/utils.xml