]> git.ipfire.org Git - people/arne_f/kernel.git/commit
can: usb_8dev: unregister netdev before free()ing
authorMarc Kleine-Budde <mkl@pengutronix.de>
Tue, 18 Jun 2013 12:33:58 +0000 (14:33 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 3 Jul 2013 17:55:37 +0000 (10:55 -0700)
commitbc0afb482febab74c665efce54507c9d70d8c6f2
tree171cd59f64edddbf5d3f3b49266ad5bdae21d6b6
parent3dec0d57dee4be55b50cc8fa8cfbf78c77a50712
can: usb_8dev: unregister netdev before free()ing

commit 4afe2156eb639e563d6ef0c2706b66ea400348b2 upstream.

The usb_8dev hardware has problems on some xhci USB hosts. The driver fails to
read the firmware revision in the probe function. This leads to the following
Oops:

    [ 3356.635912] kernel BUG at net/core/dev.c:5701!

The driver tries to free the netdev, which has already been registered, without
unregistering it.

This patch fixes the problem by unregistering the netdev in the error path.

Reported-by: Michael Olbrich <m.olbrich@pengutronix.de>
Reviewed-by: Bernd Krumboeck <krumboeck@universalnet.at>
Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
Cc: Oliver Hartkopp <socketcan@hartkopp.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/net/can/usb/usb_8dev.c