]> git.ipfire.org Git - thirdparty/postgresql.git/commit
Fix failure to detect some cases of improperly-nested aggregates.
authorTom Lane <tgl@sss.pgh.pa.us>
Mon, 13 Mar 2023 16:40:28 +0000 (12:40 -0400)
committerTom Lane <tgl@sss.pgh.pa.us>
Mon, 13 Mar 2023 16:40:28 +0000 (12:40 -0400)
commitbc0bcce2e74bf777b458e3fd815bb125dbda2ce6
treeb024665589d9535f81b30c1dc904ea1d87d8d714
parent96bef4374e450b2bd387cbfaad9371db3ac0669a
Fix failure to detect some cases of improperly-nested aggregates.

check_agg_arguments_walker() supposed that it needn't descend into
the arguments of a lower-level aggregate function, but this is
just wrong in the presence of multiple levels of sub-select.  The
oversight would lead to executor failures on queries that should
be rejected.  (Prior to v11, they actually were rejected, thanks
to a "redundant" execution-time check.)

Per bug #17835 from Anban Company.  Back-patch to all supported
branches.

Discussion: https://postgr.es/m/17835-4f29f3098b2d0ba4@postgresql.org
src/backend/parser/parse_agg.c
src/test/regress/expected/aggregates.out
src/test/regress/sql/aggregates.sql