]> git.ipfire.org Git - thirdparty/postgresql.git/commit
pg_waldump: Fix --bkp-details to not issue spurious newlines for FPWs.
authorAndres Freund <andres@anarazel.de>
Wed, 30 Oct 2019 05:46:40 +0000 (22:46 -0700)
committerAndres Freund <andres@anarazel.de>
Wed, 30 Oct 2019 05:54:36 +0000 (22:54 -0700)
commitbc4f56c181aede01715f3a44232ce3e373fc8cfb
tree763fbb4fb985ba7c8d086af9e21e2e2100e41251
parent95f2efd5041b95cb92e3940e79cbbb65c4c4b09e
pg_waldump: Fix --bkp-details to not issue spurious newlines for FPWs.

The additional newline seems to have accidentally been introduced in
2c03216d831, in 9.5. The newline is only issued when an FPW is
present for the block reference.

While there could be an argument that removing the newlines in the
back branches could cause a problem for somebody parsing the
pg_waldump output, the likelihood of that seems small enough. It seems
at least equally likely that the randomness of when newlines are
issued causes problems.

Author: Andres Freund
Discussion: https://postgr.es/m/20191029233341.4gnyau7e5v2lh5sc@alap3.anarazel.de
Backpatch: 9.5, like 2c03216d831.
src/bin/pg_xlogdump/pg_xlogdump.c