]> git.ipfire.org Git - thirdparty/qemu.git/commit
error: Kill @error_warn
authorMarkus Armbruster <armbru@redhat.com>
Tue, 23 Sep 2025 09:10:00 +0000 (11:10 +0200)
committerMarkus Armbruster <armbru@redhat.com>
Wed, 1 Oct 2025 06:33:24 +0000 (08:33 +0200)
commitbcb536cabe108e71e2900cdd605f5b4e59ac3e1f
tree947cdd20746872e40e040007951482e933d5beb1
parente0c6c38738501ff4f79864ab2b10622433317711
error: Kill @error_warn

We added @error_warn some two years ago in commit 3ffef1a55ca (error:
add global &error_warn destination).  It has multiple issues:

* error.h's big comment was not updated for it.

* Function contracts were not updated for it.

* ERRP_GUARD() is unaware of @error_warn, and fails to mask it from
  error_prepend() and such.  These crash on @error_warn, as pointed
  out by Akihiko Odaki.

All fixable.  However, after more than two years, we had just of 15
uses, of which the last few patches removed seven as unclean or
otherwise undesirable, adding back five elsewhere.  I didn't look
closely enough at the remaining seven to decide whether they are
desirable or not.

I don't think this feature earns its keep.  Drop it.

Thanks-to: Akihiko Odaki <odaki@rsg.ci.i.u-tokyo.ac.jp>
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Vladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru>
Message-ID: <20250923091000.3180122-14-armbru@redhat.com>
Reviewed-by: Akihiko Odaki <odaki@rsg.ci.i.u-tokyo.ac.jp>
hw/display/virtio-gpu.c
hw/net/virtio-net.c
include/qapi/error.h
include/system/os-win32.h
io/channel-socket.c
io/channel-watch.c
tests/unit/test-error-report.c
ui/gtk.c
util/aio-win32.c
util/error.c
util/oslib-win32.c