]> git.ipfire.org Git - thirdparty/openvpn.git/commit
dns: Fix bug in error handling when talking to script
authorFrank Lichtenheld <frank@lichtenheld.com>
Wed, 24 Sep 2025 12:18:55 +0000 (14:18 +0200)
committerGert Doering <gert@greenie.muc.de>
Wed, 24 Sep 2025 12:28:08 +0000 (14:28 +0200)
commitbd27319f2afae4c990502a434df425ff23e1e031
tree7f640883ed2f5fdac8b092c27f06ff292c88dca1
parent945db23ef49c3e8c36c6bef8857058544caa77f6
dns: Fix bug in error handling when talking to script

Comparing the result of read/write to a size_t value
is dangerous C. Since ssize_t and size_t have the same
size ssize_t is promoted to size_t, so -1 becomes
size_t max value and is not smaller than the expected
length.

Make sure to compare ssize_t to ssize_t to avoid any
suprises.

Change-Id: Ic395b6d1dce510bb4b499c5beba61f033a2a860b
Signed-off-by: Frank Lichtenheld <frank@lichtenheld.com>
Acked-by: Heiko Hund <heiko@openvpn.net>
Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/1208
Message-Id: <20250924121901.13532-1-gert@greenie.muc.de>
URL: https://sourceforge.net/p/openvpn/mailman/message/59238099/
Signed-off-by: Gert Doering <gert@greenie.muc.de>
src/openvpn/dns.c