]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
mptcp: ensure subflow is unhashed before cleaning the backlog
authorPaolo Abeni <pabeni@redhat.com>
Tue, 4 Jul 2023 20:44:33 +0000 (22:44 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 3 Aug 2023 08:24:18 +0000 (10:24 +0200)
commitbd2decac7345134ea0bd3f4b978478ef53367cd8
treea8b7f69f22fb9ec34e9b6f888f8b390f880e6d40
parentab79c7541d8461ef5cecea2079a37c30d487d17c
mptcp: ensure subflow is unhashed before cleaning the backlog

commit 3fffa15bfef48b0ad6424779c03e68ae8ace5acb upstream.

While tacking care of the mptcp-level listener I unintentionally
moved the subflow level unhash after the subflow listener backlog
cleanup.

That could cause some nasty race and makes the code harder to read.

Address the issue restoring the proper order of operations.

Fixes: 57fc0f1ceaa4 ("mptcp: ensure listener is unhashed before updating the sk status")
Cc: stable@vger.kernel.org
Signed-off-by: Paolo Abeni <pabeni@redhat.com>
Reviewed-by: Matthieu Baerts <matthieu.baerts@tessares.net>
Signed-off-by: Matthieu Baerts <matthieu.baerts@tessares.net>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Matthieu Baerts <matthieu.baerts@tessares.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
net/mptcp/protocol.c