]> git.ipfire.org Git - thirdparty/openssl.git/commit
Don't set *pval to NULL in ASN1_item_ex_new.
authorDr. Stephen Henson <steve@openssl.org>
Thu, 2 Apr 2015 12:45:14 +0000 (13:45 +0100)
committerDr. Stephen Henson <steve@openssl.org>
Fri, 10 Apr 2015 18:53:00 +0000 (19:53 +0100)
commitbd41063b1163a897333288d9789ac2ace2613783
treede03121a54a18a1f93a1055ef3be0408071cc793
parent0186f7bf87cbb1f043cbb95bc302c1e950a19462
Don't set *pval to NULL in ASN1_item_ex_new.

While *pval is usually a pointer in rare circumstances it can be a long
value. One some platforms (e.g. WIN64) where
sizeof(long) < sizeof(ASN1_VALUE *) this will write past the field.

*pval is initialised correctly in the rest of ASN1_item_ex_new so setting it
to NULL is unecessary anyway.

Thanks to Julien Kauffmann for reporting this issue.

Reviewed-by: Richard Levitte <levitte@openssl.org>
(cherry picked from commit f617b4969a9261b9d7d381670aefbe2cf766a2cb)

Conflicts:
crypto/asn1/tasn_new.c
crypto/asn1/tasn_new.c