]> git.ipfire.org Git - people/arne_f/kernel.git/commit
net: dsa: b53: Set correct number of ports in the DSA struct
authorRafał Miłecki <rafal@milecki.pl>
Thu, 2 Sep 2021 08:30:51 +0000 (10:30 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 22 Sep 2021 10:39:31 +0000 (12:39 +0200)
commitbd65986f3e2d559cc0e9e39bf18fb95dea212c6e
tree594f60dea7e4ed65bf309aecd31e87a1bea13a03
parent7c5800c3cab8182a30608a982c761fba0b20be4e
net: dsa: b53: Set correct number of ports in the DSA struct

[ Upstream commit d12e1c4649883e8ca5e8ff341e1948b3b6313259 ]

Setting DSA_MAX_PORTS caused DSA to call b53 callbacks (e.g.
b53_disable_port() during dsa_register_switch()) for invalid
(non-existent) ports. That made b53 modify unrelated registers and is
one of reasons for a broken BCM5301x support.

This problem exists for years but DSA_MAX_PORTS usage has changed few
times. It seems the most accurate to reference commit dropping
dsa_switch_alloc() in the Fixes tag.

Fixes: 7e99e3470172 ("net: dsa: remove dsa_switch_alloc helper")
Signed-off-by: Rafał Miłecki <rafal@milecki.pl>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/net/dsa/b53/b53_common.c