]> git.ipfire.org Git - thirdparty/hostap.git/commit
Fix MAC ACL query freeing on deinit
authorJouni Malinen <jouni@qca.qualcomm.com>
Wed, 8 Feb 2017 15:37:50 +0000 (17:37 +0200)
committerJouni Malinen <j@w1.fi>
Wed, 8 Feb 2017 21:48:19 +0000 (23:48 +0200)
commitbd6ec7f7cadd7f66ef613406caf6d7b2ae6ae431
tree3840cd9a3dd4e78851f2491cf77bd486d1ab743f
parentb3f32a24d4ffb50ce29f6c8f29123f2011d09b4c
Fix MAC ACL query freeing on deinit

hapd->acl_cache and hapd->acl_queries were not reset back to NULL in
hostapd_acl_deinit() when cached results and pending ACL queries were
freed. This left stale pointers to freed memory in hapd. While this was
normally followed by freeing of the hapd data, it is possible to re-use
that hapd when disabling and re-enabling an interface. That sequence
could result in use of freed memory if done while there were cached
results or pending ACL operations with a RADIUS server (especially, if
that server did not reply).

Fix this by setting hapd->acl_queries to NULL when the pending entries
are freed.

Signed-off-by: Jouni Malinen <jouni@qca.qualcomm.com>
src/ap/ieee802_11_auth.c