]> git.ipfire.org Git - thirdparty/libvirt.git/commit
Drop inline keyword from some functions.
authorMichal Privoznik <mprivozn@redhat.com>
Thu, 3 Mar 2016 07:14:37 +0000 (08:14 +0100)
committerMichal Privoznik <mprivozn@redhat.com>
Thu, 3 Mar 2016 13:39:57 +0000 (14:39 +0100)
commitbe8b536af1b11c1cbdabfb9b8f5fe760d93007c3
treea47e3f7f58f60cf6bf9e6a818fed7a4ddaed8295
parente53f2dc875f5c4865a37a2bd936858f45b23ee8e
Drop inline keyword from some functions.

While trying to build with -Os I've encountered some build
failures.

util/vircommand.c: In function 'virCommandAddEnvFormat':
util/vircommand.c:1257:1: error: inlining failed in call to 'virCommandAddEnv': call is unlikely and code size would grow [-Werror=inline]
 virCommandAddEnv(virCommandPtr cmd, char *env)
 ^
util/vircommand.c:1308:5: error: called from here [-Werror=inline]
     virCommandAddEnv(cmd, env);
     ^
This function is big enough for the compiler to be not inlined.
This is the error message I'm seeing:

Then virDomainNumatuneNodeSpecified is exported and called from
other places. It shouldn't be inlined then.

In file included from network/bridge_driver_platform.h:30:0,
                 from network/bridge_driver_platform.c:26:
network/bridge_driver_linux.c: In function 'networkRemoveRoutingFirewallRules':
./conf/network_conf.h:350:1: error: inlining failed in call to 'virNetworkDefForwardIf.constprop': call is unlikely and code size would grow [-Werror=inline]
 virNetworkDefForwardIf(const virNetworkDef *def, size_t n)
 ^

Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
src/conf/network_conf.c
src/conf/network_conf.h
src/conf/numa_conf.c
src/libvirt_private.syms
src/util/vircommand.c