]> git.ipfire.org Git - thirdparty/qemu.git/commit
hw/ppc/pnv: Do not use SysBus API to map local MMIO region
authorPhilippe Mathieu-Daudé <philmd@linaro.org>
Wed, 18 Oct 2023 05:48:11 +0000 (07:48 +0200)
committerPhilippe Mathieu-Daudé <philmd@linaro.org>
Thu, 19 Oct 2023 21:13:28 +0000 (23:13 +0200)
commitbf3b9754b7cd8ae493b186e8da2ab8d6d7145c77
treebf56c167fa2cca17751b313f94da498f3bc8563f
parentbddb677544986abed53fe9a538d207dbef8aff88
hw/ppc/pnv: Do not use SysBus API to map local MMIO region

There is no point in exposing an internal MMIO region via
SysBus and directly mapping it in the very same device.

Just map it without using the SysBus API.

Transformation done using the following coccinelle script:

  @@
  expression sbdev;
  expression index;
  expression addr;
  expression subregion;
  @@
  -    sysbus_init_mmio(sbdev, subregion);
       ... when != sbdev
  -    sysbus_mmio_map(sbdev, index, addr);
  +    memory_region_add_subregion(get_system_memory(), addr, subregion);

Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Reviewed-by: Thomas Huth <thuth@redhat.com>
Reviewed-by: LIU Zhiwei <zhiwei_liu@linux.alibaba.com>
Reviewed-by: Cédric Le Goater <clg@kaod.org>
Message-Id: <20231019131647.19690-6-philmd@linaro.org>
hw/ppc/pnv.c