]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
ASoC: tlv320aic32x4: Kernel OOPS while entering DAPM standby mode
authorb-ak <anur.bhargav@gmail.com>
Mon, 7 Jan 2019 17:00:22 +0000 (22:30 +0530)
committerBen Hutchings <ben@decadent.org.uk>
Thu, 2 May 2019 20:41:13 +0000 (21:41 +0100)
commitbf9acddc04762d7bf308a3c34bcb29c7d376044f
treec6cf2a75b1217759b435c70c3fc5d6340f0f2db0
parent1a429f7526f1e7391b6c046daa1877666b659759
ASoC: tlv320aic32x4: Kernel OOPS while entering DAPM standby mode

commit 667e9334fa64da2273e36ce131b05ac9e47c5769 upstream.

During the bootup of the kernel, the DAPM bias level is in the OFF
state. As soon as the DAPM framework kicks in it pushes the codec
into STANDBY state.

The probe function doesn't prepare the clock, and STANDBY state
does a clk_disable_unprepare() without checking the previous state.
This leads to an OOPS.

Not transitioning from an OFF state to the STANDBY state fixes the
problem.

Signed-off-by: b-ak <anur.bhargav@gmail.com>
Signed-off-by: Mark Brown <broonie@kernel.org>
[bwh: Backported to 3.16:
 - Open-code snd_soc_component_get_bias_level()
 - Adjust context]
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
sound/soc/codecs/tlv320aic32x4.c