]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
leds: qcom-lpg: Add QCOM_PBS dependency
authorArnd Bergmann <arnd@arndb.de>
Mon, 12 Feb 2024 11:15:02 +0000 (12:15 +0100)
committerLee Jones <lee@kernel.org>
Thu, 7 Mar 2024 08:48:09 +0000 (08:48 +0000)
commitbfa0f02d75860437a3271dcde5030ea610b1bd56
tree4556d02bdeec3d7e16fa310ba3e236c09c9f4021
parentec9aa8971f98ad4d0bea17a8eda60366c412e596
leds: qcom-lpg: Add QCOM_PBS dependency

The lpg driver fails to link now when the pbs driver is in a loadable module:

x86_64-linux-ld: drivers/leds/rgb/leds-qcom-lpg.o: in function `lpg_brightness_set':
leds-qcom-lpg.c:(.text+0xe7f): undefined reference to `qcom_pbs_trigger_event'
x86_64-linux-ld: drivers/leds/rgb/leds-qcom-lpg.o: in function `lpg_probe':
leds-qcom-lpg.c:(.text+0x16a5): undefined reference to `get_pbs_client_device'

Add a dependency to avoid the broken configuration. Apparently there is still
a use for lpg with pbs disabled entirely for certain chips, so allow both
but not LEDS_QCOM_LPG=y with QCOM_PBS=m.

Fixes: 214110175679 ("leds: rgb: leds-qcom-lpg: Add support for PPG through single SDAM")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Reviewed-by: Jean Delvare <jdelvare@suse.de>
Link: https://lore.kernel.org/r/20240212111526.829122-1-arnd@kernel.org
Signed-off-by: Lee Jones <lee@kernel.org>
drivers/leds/rgb/Kconfig