]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
platform/x86: toshiba_acpi: Fix the wrong variable assignment
authorKaixu Xia <kaixuxia@tencent.com>
Sun, 22 Nov 2020 05:49:37 +0000 (13:49 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 2 Dec 2020 07:34:44 +0000 (08:34 +0100)
commitbfa282f2ecf451994b24b4b0bfffd6437c343b59
treeff3e2dc5ca8b4372390688c3b01aac6d24f32c6b
parent73419262795afd60235810c5ec5fbbbf0ec72295
platform/x86: toshiba_acpi: Fix the wrong variable assignment

[ Upstream commit 2a72c46ac4d665614faa25e267c3fb27fb729ed7 ]

The commit 78429e55e4057 ("platform/x86: toshiba_acpi: Clean up
variable declaration") cleans up variable declaration in
video_proc_write(). Seems it does the variable assignment in the
wrong place, this results in dead code and changes the source code
logic. Fix it by doing the assignment at the beginning of the funciton.

Fixes: 78429e55e4057 ("platform/x86: toshiba_acpi: Clean up variable declaration")
Reported-by: Tosk Robot <tencent_os_robot@tencent.com>
Signed-off-by: Kaixu Xia <kaixuxia@tencent.com>
Link: https://lore.kernel.org/r/1606024177-16481-1-git-send-email-kaixuxia@tencent.com
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/platform/x86/toshiba_acpi.c