]> git.ipfire.org Git - thirdparty/qemu.git/commit
vnc: avoid underflow when accessing user-provided address
authorPaolo Bonzini <pbonzini@redhat.com>
Thu, 30 Mar 2023 12:23:40 +0000 (14:23 +0200)
committerMichael Tokarev <mjt@tls.msk.ru>
Thu, 27 Apr 2023 05:52:57 +0000 (08:52 +0300)
commitbfc532703f3c4f8d2744748c440ca36ce9798ccb
tree32e0d44d472747aba0c049c3fa1daf9c06b7bb36
parent161e1f22b8a288f88efa40590faab1bc4c2d86a9
vnc: avoid underflow when accessing user-provided address

If hostlen is zero, there is a possibility that addrstr[hostlen - 1]
underflows and, if a closing bracked is there, hostlen - 2 is passed
to g_strndup() on the next line.  If websocket==false then
addrstr[0] would be a colon, but if websocket==true this could in
principle happen.

Fix it by checking hostlen.

Reported by Coverity.

Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
(cherry picked from commit 3f9c41c5df9617510d8533cf6588172efb3df34b)
Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>
ui/vnc.c