]> git.ipfire.org Git - thirdparty/linux.git/commit
rcu-tasks: Add data to eliminate RCU-tasks/do_exit() deadlocks
authorPaul E. McKenney <paulmck@kernel.org>
Mon, 5 Feb 2024 21:08:22 +0000 (13:08 -0800)
committerBoqun Feng <boqun.feng@gmail.com>
Sun, 25 Feb 2024 22:18:24 +0000 (14:18 -0800)
commitbfe93930ea1ea3c6c115a7d44af6e4fea609067e
tree9ebf2232286373b3ce0dc3c24880a3f206c886b3
parent2eb52fa8900e642b3b5054c4bf9776089d2a935f
rcu-tasks: Add data to eliminate RCU-tasks/do_exit() deadlocks

Holding a mutex across synchronize_rcu_tasks() and acquiring
that same mutex in code called from do_exit() after its call to
exit_tasks_rcu_start() but before its call to exit_tasks_rcu_stop()
results in deadlock.  This is by design, because tasks that are far
enough into do_exit() are no longer present on the tasks list, making
it a bit difficult for RCU Tasks to find them, let alone wait on them
to do a voluntary context switch.  However, such deadlocks are becoming
more frequent.  In addition, lockdep currently does not detect such
deadlocks and they can be difficult to reproduce.

In addition, if a task voluntarily context switches during that time
(for example, if it blocks acquiring a mutex), then this task is in an
RCU Tasks quiescent state.  And with some adjustments, RCU Tasks could
just as well take advantage of that fact.

This commit therefore adds the data structures that will be needed
to rely on these quiescent states and to eliminate these deadlocks.

Link: https://lore.kernel.org/all/20240118021842.290665-1-chenzhongjin@huawei.com/
Reported-by: Chen Zhongjin <chenzhongjin@huawei.com>
Reported-by: Yang Jihong <yangjihong1@huawei.com>
Signed-off-by: Paul E. McKenney <paulmck@kernel.org>
Tested-by: Yang Jihong <yangjihong1@huawei.com>
Tested-by: Chen Zhongjin <chenzhongjin@huawei.com>
Reviewed-by: Frederic Weisbecker <frederic@kernel.org>
Signed-off-by: Boqun Feng <boqun.feng@gmail.com>
include/linux/sched.h
kernel/rcu/tasks.h