]> git.ipfire.org Git - thirdparty/qemu.git/commit
tcg: update the cpu running flag in cpu_exec_step_atomic
authorDouglas Crosher <dtc-ubuntu@scieneer.com>
Tue, 22 Sep 2020 07:42:41 +0000 (17:42 +1000)
committerRichard Henderson <richard.henderson@linaro.org>
Fri, 22 Jan 2021 22:48:01 +0000 (12:48 -1000)
commitbfff072c5035b8dfbdebeb6b9143f3ae8fe9f9f4
treedcd2cde5658380681e509bc34457db6d87749408
parent0e32462630687a18039464511bd0447ada5709c3
tcg: update the cpu running flag in cpu_exec_step_atomic

The cpu_exec_step_atomic() function is called with the cpu->running
clear and proceeds to run target code without setting this flag. If
this target code generates an exception then handle_cpu_signal() will
unnecessarily abort.  For example if atomic code generates a memory
protection fault.

This patch at least sets and clears this running flag, and adds some
assertions to help detect other cases.

Signed-off-by: Douglas Crosher <dtc-ubuntu@scieneer.com>
Message-Id: <a272c656-f7c5-019d-1cc0-499b8f80f2fc@scieneer.com>
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
accel/tcg/cpu-exec.c