]> git.ipfire.org Git - thirdparty/gcc.git/commit
selftest: Work around GCC 4.2 PR33916 bug by optimizing the ctor [PR89494]
authorGustavo Romero <gromero@linux.ibm.com>
Wed, 15 Apr 2020 13:14:45 +0000 (15:14 +0200)
committerJakub Jelinek <jakub@redhat.com>
Wed, 15 Apr 2020 13:14:45 +0000 (15:14 +0200)
commitc00568f376078129196740d83946d54dc5437401
tree9db39f1ab7db4c770ab338ccc8548d9a2f07149e
parent8a4436d89bfa0f731a48bf28d521f4b1b91014d7
selftest: Work around GCC 4.2 PR33916 bug by optimizing the ctor [PR89494]

GCC 4.2 due to PR33916 miscompiles temp_dump_context ctor, because it doesn't
zero initialize the whole dump_context temporary on which it runs the static
get method and during destruction of the temporary an uninitialized pointer
is deleted.

More recent GCC versions properly zero initialize it and ideally optimize away
the construction/destruction of the temporary, as it isn't used for anything,
but there is no reason to create the temporary, static member functions can
be called without an associated object.

2020-04-15  Gustavo Romero  <gromero@linux.ibm.com>

PR bootstrap/89494
* dumpfile.c (selftest::temp_dump_context::temp_dump_context):
Don't construct a dump_context temporary to call static method.
gcc/ChangeLog
gcc/dumpfile.c