]> git.ipfire.org Git - thirdparty/linux.git/commit
drm/vc4: fix infinite EPROBE_DEFER loop
authorGabriel Dalimonte <gabriel.dalimonte@gmail.com>
Sun, 1 Jun 2025 16:45:36 +0000 (12:45 -0400)
committerMaxime Ripard <mripard@kernel.org>
Tue, 10 Jun 2025 08:47:04 +0000 (10:47 +0200)
commitc0317ad44f45b3c1f0ff46a4e28d14c7bccdedf4
treebd1fef518b511e5175e0999c68f0e8bec0657e26
parent779a0c9e06a91d0007f2a4f4071e3b9a8102b15e
drm/vc4: fix infinite EPROBE_DEFER loop

`vc4_hdmi_audio_init` calls `devm_snd_dmaengine_pcm_register` which may
return EPROBE_DEFER. Calling `drm_connector_hdmi_audio_init` adds a
child device. The driver model docs[1] state that adding a child device
prior to returning EPROBE_DEFER may result in an infinite loop.

[1] https://www.kernel.org/doc/html/v6.14/driver-api/driver-model/driver.html

Fixes: 9640f1437a88 ("drm/vc4: hdmi: switch to using generic HDMI Codec infrastructure")
Signed-off-by: Gabriel Dalimonte <gabriel.dalimonte@gmail.com>
Link: https://lore.kernel.org/r/20250601-vc4-audio-inf-probe-v2-1-9ad43c7b6147@gmail.com
Signed-off-by: Maxime Ripard <mripard@kernel.org>
drivers/gpu/drm/vc4/vc4_hdmi.c